Skip to content

674.force checkout option #679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
singhd789 wants to merge 27 commits into
base: main
Choose a base branch
from
Open

674.force checkout option #679

singhd789 wants to merge 27 commits into from

Conversation

@singhd789
Copy link
Collaborator

@singhd789 singhd789 commented Nov 20, 2025 •
edited
Loading

Describe your changes

  • Adds --force-checkout option to fre make: if the checkout script already exists but the user made a change to the yaml, this option can be used to remove and re-create the checkout script
  • removes verbose options at fre make checkout-script level (already implemented at fre level)
  • fixes up some format across files
  • updates logging level format

Issue ticket number and link (if applicable)

#674

Checklist before requesting a review

  • I ran my code
  • I tried to make my code readable
  • I tried to comment my code
  • I wrote a new test, if applicable
  • I wrote new instructions/documentation, if applicable
  • I ran pytest and inspected it's output
  • I ran pylint and attempted to implement some of it's feedback
  • No print statements; all user-facing info uses logging module

@codecov
Copy link

codecov bot commented Dec 9, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 90.74074% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.26%. Comparing base (982868f) to head (8575c19).

Files with missing lines Patch % Lines
fre/make/create_checkout_script.py 88.37% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #679      +/-   ##
==========================================
- Coverage   85.30%   85.26%   -0.04%     
==========================================
  Files          68       68              
  Lines        4498     4513      +15     
==========================================
+ Hits         3837     3848      +11     
- Misses        661      665       +4
Flag Coverage Δ
unittests 85.26% <90.74%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@singhd789 singhd789 linked an issue Dec 9, 2025 that may be closed by this pull request
Add force-checkout option in fre make subtool #674
Open
Dana Singh and others added 17 commits December 10, 2025 11:53
Merge branch 'main' of github.com:NOAA-GFDL/fre-cli into 674.force-c…
c76c0b1 
…heckout-option
#674 Add force-checkout option for container use
4cd7a3d
#674 Some cleanup
1718cc8
#674 Merge branch '674.force-checkout-option' of github.com:NOAA-GFD…
f869e75 
…L/fre-cli into 674.force-checkout-option
#674 Update to f-strings
1b803a4
#674 Address pylint messages
5a260cf
#674 Add mktemplate to ok spelling
a04870e
@singhd789
#674 Merge branch 'main' of github.com:NOAA-GFDL/fre-cli into 674.fo…
8244e8b 
…rce-checkout-option
@singhd789
#674 Merge branch '674.force-checkout-option' of github.com:NOAA-GFD…
69b5ffb 
…L/fre-cli into 674.force-checkout-option
#674 Remove verbose option (this is already done on the fre level)
69aa3e7 
- set logging level here
#674 Merge branch 'main' of github.com:NOAA-GFDL/fre-cli into 674.fo…
d010a7a 
…rce-checkout-option
#674 Merge branch '674.force-checkout-option' of github.com:NOAA-GFD…
eb2672d 
…L/fre-cli into 674.force-checkout-option
#674 Move around setting level of logger
9da15bd
#674 Update and add to checkout test script
eb7c3a1
#674 Add output back in
eca2d74
#674 Remove verbose options
7ff5846
#674 Address some pylint messages
87a5649
@singhd789 singhd789 marked this pull request as ready for review December 30, 2025 18:26
@singhd789 singhd789 mentioned this pull request Jan 6, 2026
Open
8 tasks
@singhd789
Copy link
Collaborator Author

singhd789 commented Jan 14, 2026

Note: test failure in fre/make/tests/compilation/test_run_fremake_builds.py::test_run_fremake_container_build_fail fixed by this PR: #691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@uramirez8707 uramirez8707 Awaiting requested review from uramirez8707

@ilaflott ilaflott Awaiting requested review from ilaflott

@thomas-robinson thomas-robinson Awaiting requested review from thomas-robinson

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add force-checkout option in fre make subtool

2 participants

@singhd789